Skip to content

add Stripe payment methods management for teams #6483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add Stripe payment methods management for teams #6483

wants to merge 1 commit into from

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 17, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces payment method management features to the dashboard, integrating @stripe/react-stripe-js and @stripe/stripe-js for handling payment methods, including adding, deleting, and setting default payment methods.

Detailed summary

  • Added @stripe/react-stripe-js and @stripe/stripe-js dependencies.
  • Updated page.tsx to fetch paymentMethods alongside subscriptions.
  • Modified Billing component to accept and display paymentMethods.
  • Created PaymentMethodsClient for managing payment methods.
  • Implemented addPaymentMethod, deletePaymentMethod, and setDefaultPaymentMethod actions.
  • Introduced PaymentMethodIcon for displaying payment method types.
  • Added AddPaymentMethodForm for adding new payment methods with Stripe integration.
  • Implemented validation and error handling for payment method actions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:58pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 17, 2025 11:58pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 17, 2025 11:58pm
wallet-ui ⬜️ Skipped (Inspect) Mar 17, 2025 11:58pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 19:53 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 17, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Mar 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review March 17, 2025 19:55
@jnsdls jnsdls requested review from a team as code owners March 17, 2025 19:55
@socket-security
Copy link

socket-security bot commented Mar 17, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@stripe/react-stripe-js@3.4.0 Transitive: environment +5 649 kB dodgez-stripe
npm/@stripe/stripe-js@6.1.0 None 0 941 kB cbala-stripe

View full report↗︎

@jnsdls jnsdls force-pushed the add_Stripe_payment_methods_management_for_teams branch from d789b6f to 8d6a3d2 Compare March 17, 2025 19:56
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ea4c84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 19:56 Inactive
@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (f2e61b8) to head (9ea4c84).
Report is 73 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6483      +/-   ##
==========================================
+ Coverage   54.80%   54.82%   +0.01%     
==========================================
  Files         875      875              
  Lines       54851    54851              
  Branches     3738     3740       +2     
==========================================
+ Hits        30062    30071       +9     
+ Misses      24695    24685      -10     
- Partials       94       95       +1
Flag Coverage Δ
packages ∅ <ø> (∅)

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 159 ms (+179.5% 🔺) 1.1 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 251 ms (+54.12% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 106 ms (+2161.74% 🔺) 219 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 49 ms (+2019.66% 🔺) 59 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 106 ms (+929.34% 🔺) 493 ms

@jnsdls jnsdls force-pushed the add_Stripe_payment_methods_management_for_teams branch from 8d6a3d2 to 05942bc Compare March 17, 2025 21:35
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 21:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 21:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 21:35 Inactive
graphite-app[bot]
graphite-app bot reviewed Mar 17, 2025
View reviewed changes
@jnsdls jnsdls force-pushed the add_Stripe_payment_methods_management_for_teams branch from 05942bc to 86f1a0e Compare March 17, 2025 21:42
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 21:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 21:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 21:42 Inactive
@jnsdls jnsdls force-pushed the add_Stripe_payment_methods_management_for_teams branch from 86f1a0e to 900b1eb Compare March 17, 2025 21:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 21:43 Inactive
graphite-app[bot]
graphite-app bot reviewed Mar 17, 2025
View reviewed changes
@jnsdls jnsdls force-pushed the add_Stripe_payment_methods_management_for_teams branch from 900b1eb to b161ce7 Compare March 17, 2025 23:45
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 23:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 23:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 23:45 Inactive
@jnsdls jnsdls force-pushed the add_Stripe_payment_methods_management_for_teams branch from b161ce7 to 9ea4c84 Compare March 17, 2025 23:46
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 17, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 17, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 17, 2025 23:46 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Mar 25, 2025
@github-actions github-actions bot closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard. Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnsdls